Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add alternateRowsColor for Tree Table presenter. #1458

Merged

Conversation

hernanmd
Copy link
Member

Summary

This PR proposes adding row color alternation support to the SpTreeTablePresenter to bring its functionality in line with the similar SpTablePresenter.

Details

The SpTreeTablePrccesenter currently lacks a method for alternating row colors, a feature that is available in the SpTablePresenter. This enhancement aims to bring consistency between these two widgets by adding a new method, alternateRowsColor, to SpTreeTablePresenter.

Testing:

A unit test have been added to ensure the correct behavior of the alternateRowsColor method.
Manual testing has been performed to validate the feature's functionality within the SpTreeTablePresenter.

Why is this change needed?

This change is useful to maintain consistency across Spec. Users who are familiar with the SpTablePresenter widget expect similar functionality in the SpTreeTablePresenter.

Screenshots

Screenshot 2023-09-25 at 12 10 10

@hernanmd
Copy link
Member Author

Failing tests are not related with the PR.

@jecisc jecisc merged commit 898acf0 into pharo-spec:Pharo12 Sep 25, 2023
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants